CSR-222: update button-back component; rename site-header and header components
This commit is contained in:
parent
20fbdb588c
commit
46865fe2bc
11 changed files with 113 additions and 56 deletions
|
|
@ -1,12 +1,12 @@
|
||||||
import { shallowMount } from "@vue/test-utils";
|
import { shallowMount } from "@vue/test-utils";
|
||||||
import siteHeader from "./site-header";
|
import funnelHeader from "./funnel-header";
|
||||||
|
|
||||||
describe("siteHeader", () => {
|
describe("funnelHeader", () => {
|
||||||
test("renders the logo image", () => {
|
test("renders the logo image", () => {
|
||||||
// Arrange
|
// Arrange
|
||||||
|
|
||||||
// Act
|
// Act
|
||||||
const wrapper = shallowMount(siteHeader, {
|
const wrapper = shallowMount(funnelHeader, {
|
||||||
propsData: {
|
propsData: {
|
||||||
imageSrc: "image_url",
|
imageSrc: "image_url",
|
||||||
},
|
},
|
||||||
|
|
@ -9,11 +9,12 @@
|
||||||
|
|
||||||
<script>
|
<script>
|
||||||
export default {
|
export default {
|
||||||
name: "site-header",
|
name: "funnel-header",
|
||||||
props: {
|
props: {
|
||||||
imageSrc: {
|
imageSrc: {
|
||||||
type: String,
|
type: String,
|
||||||
required: true,
|
required: true,
|
||||||
|
default: "",
|
||||||
},
|
},
|
||||||
},
|
},
|
||||||
};
|
};
|
||||||
|
|
@ -0,0 +1,16 @@
|
||||||
|
import { shallowMount } from "@vue/test-utils";
|
||||||
|
import FunnelSubHeader from "./funnel-sub-header";
|
||||||
|
|
||||||
|
describe("FunnelSubHeader.vue", () => {
|
||||||
|
it("Should render the 'text' prop value as a span value for the header span text value.", () => {
|
||||||
|
// Act
|
||||||
|
const wrapper = shallowMount(FunnelSubHeader, {
|
||||||
|
propsData: {
|
||||||
|
text: "FunnelSubHeader Content",
|
||||||
|
},
|
||||||
|
});
|
||||||
|
|
||||||
|
// Assert
|
||||||
|
expect(wrapper.find("h2").text()).toContain("FunnelSubHeader Content");
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
@ -0,0 +1,38 @@
|
||||||
|
<template>
|
||||||
|
<div class="current_car_info-text">
|
||||||
|
<div class="d-flex align-items-center justify-content-center">
|
||||||
|
<h2 class="text-center fs-5 d-block fw-normal mb-0">{{ text }}</h2>
|
||||||
|
<buttonBack
|
||||||
|
v-if="hasBackButton"
|
||||||
|
:backButtonUrl="backButtonUrl"
|
||||||
|
:backButtonAccessibleText="backButtonAccessibleText"
|
||||||
|
/>
|
||||||
|
</div>
|
||||||
|
</div>
|
||||||
|
</template>
|
||||||
|
|
||||||
|
<script>
|
||||||
|
import buttonBack from "@/ux-components/button-back/button-back";
|
||||||
|
|
||||||
|
export default {
|
||||||
|
name: "FunnelSubHeader",
|
||||||
|
props: {
|
||||||
|
text: String,
|
||||||
|
hasBackButton: Boolean,
|
||||||
|
backButtonUrl: String,
|
||||||
|
backButtonAccessibleText: String,
|
||||||
|
},
|
||||||
|
components: {
|
||||||
|
buttonBack,
|
||||||
|
}
|
||||||
|
};
|
||||||
|
</script>
|
||||||
|
|
||||||
|
<style lang="scss">
|
||||||
|
h2 {
|
||||||
|
color: $gray-550;
|
||||||
|
}
|
||||||
|
.back-button-wrapper {
|
||||||
|
margin-left: .25rem;
|
||||||
|
}
|
||||||
|
</style>
|
||||||
|
|
@ -15,6 +15,7 @@ export default {
|
||||||
vehicleImageSrc: {
|
vehicleImageSrc: {
|
||||||
type: String,
|
type: String,
|
||||||
required: true,
|
required: true,
|
||||||
|
default: "",
|
||||||
},
|
},
|
||||||
},
|
},
|
||||||
};
|
};
|
||||||
|
|
|
||||||
|
|
@ -52,7 +52,10 @@
|
||||||
</div>
|
</div>
|
||||||
<div class="row">
|
<div class="row">
|
||||||
<div class="col my-3 d-flex align-items-center">
|
<div class="col my-3 d-flex align-items-center">
|
||||||
<buttonBack/>
|
<buttonBack
|
||||||
|
backButtonUrl="#"
|
||||||
|
backButtonAccessibleText="Back button label"
|
||||||
|
/>
|
||||||
</div>
|
</div>
|
||||||
</div>
|
</div>
|
||||||
<div class="row my-4">
|
<div class="row my-4">
|
||||||
|
|
@ -398,7 +401,7 @@
|
||||||
</div>
|
</div>
|
||||||
<div class="row my-3">
|
<div class="row my-3">
|
||||||
<div class="col">
|
<div class="col">
|
||||||
<siteHeader
|
<funnelHeader
|
||||||
imageSrc="https://digitalconsumercms-dev.safelite.com/images/default-source/default-album/safelite-logo.svg?sfvrsn=45e7ed06_3"
|
imageSrc="https://digitalconsumercms-dev.safelite.com/images/default-source/default-album/safelite-logo.svg?sfvrsn=45e7ed06_3"
|
||||||
/>
|
/>
|
||||||
</div>
|
</div>
|
||||||
|
|
@ -426,7 +429,7 @@ import listCard from "@/ux-components/list-card/list-card";
|
||||||
import listButton from "@/ux-components/list-button/list-button";
|
import listButton from "@/ux-components/list-button/list-button";
|
||||||
import alert from "@/ux-components/alert/alert";
|
import alert from "@/ux-components/alert/alert";
|
||||||
import vehicleBanner from "@/common-components/vehicle-banner/vehicle-banner";
|
import vehicleBanner from "@/common-components/vehicle-banner/vehicle-banner";
|
||||||
import siteHeader from "@/common-components/site-header/site-header";
|
import funnelHeader from "@/common-components/funnel-header/funnel-header";
|
||||||
import listButtonHorizontal from "@/ux-components/list-button-horizontal/list-button-horizontal";
|
import listButtonHorizontal from "@/ux-components/list-button-horizontal/list-button-horizontal";
|
||||||
export default {
|
export default {
|
||||||
name: "App",
|
name: "App",
|
||||||
|
|
@ -439,7 +442,7 @@ export default {
|
||||||
alert,
|
alert,
|
||||||
vehicleBanner,
|
vehicleBanner,
|
||||||
listButtonHorizontal,
|
listButtonHorizontal,
|
||||||
siteHeader,
|
funnelHeader,
|
||||||
},
|
},
|
||||||
data() {
|
data() {
|
||||||
return {
|
return {
|
||||||
|
|
|
||||||
|
|
@ -1,10 +1,13 @@
|
||||||
<template v-if="isCmsContentReady">
|
<template v-if="isCmsContentReady">
|
||||||
<div class="container-fluid shadow rounded-3 p-0">
|
<div class="container-fluid shadow rounded-3 p-0">
|
||||||
<siteHeader :imageSrc="siteHeaderWidget.LogoImage" />
|
<funnelHeader :imageSrc="siteHeaderWidget.LogoImage" />
|
||||||
<div class="select-car">
|
<div class="select-car">
|
||||||
<div class="select-car-form rounded text-center">
|
<div class="select-car-form rounded text-center">
|
||||||
<vehicleBanner :vehicleImageSrc="vehicleBannerWidget.GenericVehicleImage" />
|
<vehicleBanner :vehicleImageSrc="vehicleBannerWidget.GenericVehicleImage" />
|
||||||
<pageHeader :text="pageHeaderWidgets.HeaderText" class="Header" />
|
<funnelSubHeader
|
||||||
|
:text="pageHeaderWidgets.HeaderText"
|
||||||
|
class="Header"
|
||||||
|
/>
|
||||||
<yearQuestion v-model="selectedYear" ref="yearQuestion" />
|
<yearQuestion v-model="selectedYear" ref="yearQuestion" />
|
||||||
</div>
|
</div>
|
||||||
</div>
|
</div>
|
||||||
|
|
@ -14,9 +17,9 @@
|
||||||
<script>
|
<script>
|
||||||
// Components
|
// Components
|
||||||
import yearQuestion from "@/layouts/vehicle-year/year-question/year-question";
|
import yearQuestion from "@/layouts/vehicle-year/year-question/year-question";
|
||||||
import pageHeader from "@/ux-components/header/header";
|
import funnelHeader from "@/common-components/funnel-header/funnel-header";
|
||||||
import siteHeader from "@/common-components/site-header/site-header";
|
|
||||||
import vehicleBanner from "@/common-components/vehicle-banner/vehicle-banner";
|
import vehicleBanner from "@/common-components/vehicle-banner/vehicle-banner";
|
||||||
|
import funnelSubHeader from "@/common-components/funnel-sub-header/funnel-sub-header";
|
||||||
// Supporting files
|
// Supporting files
|
||||||
import { fetchCmsContentForPage } from "@/helpers/cms-content-helper";
|
import { fetchCmsContentForPage } from "@/helpers/cms-content-helper";
|
||||||
import { settleAllPromises } from "@/helpers/layout-helper";
|
import { settleAllPromises } from "@/helpers/layout-helper";
|
||||||
|
|
@ -70,9 +73,9 @@ export default {
|
||||||
|
|
||||||
components: {
|
components: {
|
||||||
yearQuestion,
|
yearQuestion,
|
||||||
pageHeader,
|
funnelHeader,
|
||||||
siteHeader,
|
|
||||||
vehicleBanner,
|
vehicleBanner,
|
||||||
|
funnelSubHeader,
|
||||||
},
|
},
|
||||||
};
|
};
|
||||||
</script>
|
</script>
|
||||||
|
|
|
||||||
|
|
@ -1 +1,20 @@
|
||||||
test.todo("some test to be written in the future");
|
import { shallowMount } from "@vue/test-utils";
|
||||||
|
import buttonBack from "./button-back";
|
||||||
|
|
||||||
|
describe("back button", () => {
|
||||||
|
test("renders a link", () => {
|
||||||
|
// Arrange
|
||||||
|
|
||||||
|
// Act
|
||||||
|
const wrapper = shallowMount(buttonBack, {
|
||||||
|
propsData: {
|
||||||
|
backButtonUrl: "#",
|
||||||
|
backButtonAccessibleText: "something",
|
||||||
|
},
|
||||||
|
});
|
||||||
|
|
||||||
|
// Assert
|
||||||
|
expect(wrapper.find("a").exists()).toBe(true);
|
||||||
|
wrapper.unmount();
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
@ -1,15 +1,26 @@
|
||||||
<template>
|
<template>
|
||||||
<button class="back-button-wrapper d-flex p-0">
|
<a v-if="backButtonUrl" :href="backButtonUrl" class="back-button-wrapper d-flex p-0" :aria-label="backButtonAccessibleText">
|
||||||
<div class="button-back">
|
<div class="button-back">
|
||||||
<div class="arrow-left"></div>
|
<div class="arrow-left"></div>
|
||||||
<div class="box"></div>
|
<div class="box"></div>
|
||||||
</div>
|
</div>
|
||||||
</button>
|
</a>
|
||||||
</template>
|
</template>
|
||||||
|
|
||||||
<script>
|
<script>
|
||||||
export default {
|
export default {
|
||||||
name: "buttonBack"
|
name: "buttonBack",
|
||||||
|
props: {
|
||||||
|
backButtonUrl: {
|
||||||
|
type: String,
|
||||||
|
required: true,
|
||||||
|
default: "",
|
||||||
|
},
|
||||||
|
backButtonAccessibleText: {
|
||||||
|
type: String,
|
||||||
|
required: true,
|
||||||
|
},
|
||||||
|
},
|
||||||
};
|
};
|
||||||
</script>
|
</script>
|
||||||
|
|
||||||
|
|
@ -17,6 +28,9 @@ export default {
|
||||||
.back-button-wrapper {
|
.back-button-wrapper {
|
||||||
border: none;
|
border: none;
|
||||||
background: transparent;
|
background: transparent;
|
||||||
|
text-decoration: none;
|
||||||
|
border-bottom: none;
|
||||||
|
|
||||||
.button-back {
|
.button-back {
|
||||||
display: inline-flex;
|
display: inline-flex;
|
||||||
position: relative;
|
position: relative;
|
||||||
|
|
|
||||||
|
|
@ -1,16 +0,0 @@
|
||||||
import { shallowMount } from "@vue/test-utils";
|
|
||||||
import Header from "./header";
|
|
||||||
|
|
||||||
describe("Header.vue", () => {
|
|
||||||
it("Should render the 'text' prop value as a span value for the header span text value.", () => {
|
|
||||||
// Act
|
|
||||||
const wrapper = shallowMount(Header, {
|
|
||||||
propsData: {
|
|
||||||
text: "Header Content",
|
|
||||||
},
|
|
||||||
});
|
|
||||||
|
|
||||||
// Assert
|
|
||||||
expect(wrapper.find("h2").text()).toContain("Header Content");
|
|
||||||
});
|
|
||||||
});
|
|
||||||
|
|
@ -1,22 +0,0 @@
|
||||||
<template>
|
|
||||||
<div class="current_car_info-text">
|
|
||||||
<div class="d-flex align-items-center justify-content-center">
|
|
||||||
<h2 class="text-center fs-5 d-block fw-normal mb-0">{{ text }}</h2>
|
|
||||||
</div>
|
|
||||||
</div>
|
|
||||||
</template>
|
|
||||||
|
|
||||||
<script>
|
|
||||||
export default {
|
|
||||||
name: "Header",
|
|
||||||
props: {
|
|
||||||
text: String,
|
|
||||||
},
|
|
||||||
};
|
|
||||||
</script>
|
|
||||||
|
|
||||||
<style lang="scss">
|
|
||||||
h2 {
|
|
||||||
color: $gray-550;
|
|
||||||
}
|
|
||||||
</style>
|
|
||||||
Loading…
Reference in a new issue