From ff6a45e6e420a311444f7b5a03f3b4acc3b34945 Mon Sep 17 00:00:00 2001 From: Katie Date: Tue, 13 Sep 2022 17:11:52 -0400 Subject: [PATCH 1/3] CSR-835 Update list-button-horizontal, getPartsOrQuestions call --- src/store/index.js | 2 +- .../list-button-horizontal/list-button-horizontal.vue | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/store/index.js b/src/store/index.js index 0a57a82a3..dd2a59683 100644 --- a/src/store/index.js +++ b/src/store/index.js @@ -717,7 +717,7 @@ export const actions = { endpoint: endpoints.GetPartsOrQuestions.url, payload: { carId: carId, - glass: glassArray, + glass: glassArray ?? [], zip: zipCode, vin: vin }, diff --git a/src/ux-components/list-button-horizontal/list-button-horizontal.vue b/src/ux-components/list-button-horizontal/list-button-horizontal.vue index 7011835b9..84d9c715b 100644 --- a/src/ux-components/list-button-horizontal/list-button-horizontal.vue +++ b/src/ux-components/list-button-horizontal/list-button-horizontal.vue @@ -14,7 +14,6 @@ :name="groupName" :value="value" :aria-required="isRequired" - v-model="checkValue" :checked="checkValue" @change="handleInputChange()" /> @@ -91,7 +90,7 @@ export default { if (Array.isArray(this.selectedValues)) { this.checkValue = this.isMultiSelect ? this.selectedValues.includes(this.value) - : this.selectedValues[0]; + : this.selectedValues[0] == this.value; } }, methods: { From 4c2fbba29eb6fe79803565f9d830ffb9f51fb026 Mon Sep 17 00:00:00 2001 From: Katie Date: Tue, 13 Sep 2022 19:00:20 -0400 Subject: [PATCH 2/3] CSR-385 Fix list-button-horizontal --- .../list-button-horizontal/list-button-horizontal.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ux-components/list-button-horizontal/list-button-horizontal.vue b/src/ux-components/list-button-horizontal/list-button-horizontal.vue index 84d9c715b..94bd59534 100644 --- a/src/ux-components/list-button-horizontal/list-button-horizontal.vue +++ b/src/ux-components/list-button-horizontal/list-button-horizontal.vue @@ -12,8 +12,8 @@ :type="isMultiSelect ? 'checkbox' : 'radio'" :id="buttonID" :name="groupName" - :value="value" :aria-required="isRequired" + v-model="checkValue" :checked="checkValue" @change="handleInputChange()" /> From d8fa80bbe1de272768692a5329c1c90198d5c0f1 Mon Sep 17 00:00:00 2001 From: Katie Date: Tue, 13 Sep 2022 19:08:26 -0400 Subject: [PATCH 3/3] CSR-835 Fix broken test --- .../list-button-horizontal/list-button-horizontal.spec.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/ux-components/list-button-horizontal/list-button-horizontal.spec.js b/src/ux-components/list-button-horizontal/list-button-horizontal.spec.js index 5c288f660..08aaad712 100644 --- a/src/ux-components/list-button-horizontal/list-button-horizontal.spec.js +++ b/src/ux-components/list-button-horizontal/list-button-horizontal.spec.js @@ -211,11 +211,12 @@ describe("list-button-horizontal.vue", () => { isWide: false, modelValue: ["List Card Checkbox"], isMultiSelect: false, + value: "Car-Front", selectedValues: ["Car-Front"] }, }); // Assert - expect(wrapper.componentVM.checkValue).toEqual("Car-Front"); + expect(wrapper.vm.checkValue).toEqual(true); }); it("Should run handleCheckChange if selectingInitiatesLoad is false and handleInputChange is triggered", async () => {