From 3dd2fac254e80d8900c7298723f8b905aea2dc4b Mon Sep 17 00:00:00 2001 From: Leah Schumann Date: Thu, 24 Aug 2023 08:26:33 -0400 Subject: [PATCH 01/21] Added sonarqube support files --- .scannerwork/.sonar_lock | 0 .scannerwork/report-task.txt | 6 ++++++ sonar-project.properties | 10 ++++++++++ 3 files changed, 16 insertions(+) create mode 100644 .scannerwork/.sonar_lock create mode 100644 .scannerwork/report-task.txt create mode 100644 sonar-project.properties diff --git a/.scannerwork/.sonar_lock b/.scannerwork/.sonar_lock new file mode 100644 index 000000000..e69de29bb diff --git a/.scannerwork/report-task.txt b/.scannerwork/report-task.txt new file mode 100644 index 000000000..dbcf1e585 --- /dev/null +++ b/.scannerwork/report-task.txt @@ -0,0 +1,6 @@ +projectKey=DigitalConsumer.FixMyGlass +serverUrl=http://localhost:9000 +serverVersion=10.1.0.73491 +dashboardUrl=http://localhost:9000/dashboard?id=DigitalConsumer.FixMyGlass +ceTaskId=AYnlDa50m2ysCZ4aQNIX +ceTaskUrl=http://localhost:9000/api/ce/task?id=AYnlDa50m2ysCZ4aQNIX diff --git a/sonar-project.properties b/sonar-project.properties new file mode 100644 index 000000000..c849286c4 --- /dev/null +++ b/sonar-project.properties @@ -0,0 +1,10 @@ +# must be unique in a given SonarQube instance +sonar.projectKey=DigitalConsumer.FixMyGlass + +# --- optional properties --- + +# defaults to project key +sonar.projectName=DigitalConsumer.FixMyGlass + +# defaults to 'not provided' +sonar.projectVersion=1.0 \ No newline at end of file From 78c53d6777847b94baf6c2b75b99f7a8413ddd1d Mon Sep 17 00:00:00 2001 From: Leah Schumann Date: Thu, 24 Aug 2023 08:26:33 -0400 Subject: [PATCH 02/21] Revert "Added sonarqube support files" This reverts commit 3dd2fac254e80d8900c7298723f8b905aea2dc4b. --- .scannerwork/.sonar_lock | 0 .scannerwork/report-task.txt | 6 ------ sonar-project.properties | 10 ---------- 3 files changed, 16 deletions(-) delete mode 100644 .scannerwork/.sonar_lock delete mode 100644 .scannerwork/report-task.txt delete mode 100644 sonar-project.properties diff --git a/.scannerwork/.sonar_lock b/.scannerwork/.sonar_lock deleted file mode 100644 index e69de29bb..000000000 diff --git a/.scannerwork/report-task.txt b/.scannerwork/report-task.txt deleted file mode 100644 index dbcf1e585..000000000 --- a/.scannerwork/report-task.txt +++ /dev/null @@ -1,6 +0,0 @@ -projectKey=DigitalConsumer.FixMyGlass -serverUrl=http://localhost:9000 -serverVersion=10.1.0.73491 -dashboardUrl=http://localhost:9000/dashboard?id=DigitalConsumer.FixMyGlass -ceTaskId=AYnlDa50m2ysCZ4aQNIX -ceTaskUrl=http://localhost:9000/api/ce/task?id=AYnlDa50m2ysCZ4aQNIX diff --git a/sonar-project.properties b/sonar-project.properties deleted file mode 100644 index c849286c4..000000000 --- a/sonar-project.properties +++ /dev/null @@ -1,10 +0,0 @@ -# must be unique in a given SonarQube instance -sonar.projectKey=DigitalConsumer.FixMyGlass - -# --- optional properties --- - -# defaults to project key -sonar.projectName=DigitalConsumer.FixMyGlass - -# defaults to 'not provided' -sonar.projectVersion=1.0 \ No newline at end of file From a462d768c0a34f8856865e40834f2b4621b7cf8a Mon Sep 17 00:00:00 2001 From: Sneha Date: Tue, 29 Aug 2023 13:00:48 +0530 Subject: [PATCH 03/21] Update vehicle.vue --- src/layouts/vehicle/vehicle.vue | 41 +++++++++++++++++++++++++++++---- 1 file changed, 37 insertions(+), 4 deletions(-) diff --git a/src/layouts/vehicle/vehicle.vue b/src/layouts/vehicle/vehicle.vue index 37e813bed..49d99bef7 100644 --- a/src/layouts/vehicle/vehicle.vue +++ b/src/layouts/vehicle/vehicle.vue @@ -29,6 +29,7 @@ :isDisabled="!makeOptions.length" :options="makeOptions" cmsWidgetName="VehicleMakeQuestion" + v-validate="{ rules: 'required', disabled: !makeOptions.length }" validationRules="make-required" placeHolderText="Select make" inputId="makeQuestionField" /> @@ -40,6 +41,7 @@ cmsWidgetName="VehicleModelQuestion" :isDisabled="!modelOptions.length" :options="modelOptions" + v-validate="{ rules: 'required', disabled: !modelOptions.length }" validationRules="model-required" placeHolderText="Select model" inputId="modelQuestionField" /> @@ -51,6 +53,7 @@ cmsWidgetName="VehicleStyleQuestion" :isDisabled="!styleOptions.length" :options="styleOptions" + v-validate="{ rules: 'required', disabled: !styleOptions.length }" validationRules="style-required" placeHolderText="Select style" inputId="styleQuestionField" /> @@ -99,10 +102,34 @@ import { storeActions } from "@/constants/store-actions.js"; import baseMixin from "@/mixins/base-mixin.js"; //define validation rules -defineRule("year-required", required(errorMessages.YEAR_REQUIRED)); -defineRule("make-required", required(errorMessages.MAKE_REQUIRED)); -defineRule("model-required", required(errorMessages.MODEL_REQUIRED)); -defineRule("style-required", required(errorMessages.STYLE_REQUIRED)); +defineRule("year-required", (value) => { + if (!value || !value.length ) { + return errorMessages.YEAR_REQUIRED; + } + return true; +}); +defineRule("make-required", (value) => { + if (!value || !value.length) { + return errorMessages.MAKE_REQUIRED; + } + return true; +}); +defineRule("model-required", (value) => { + if (!value || !value.length) { + return errorMessages.MODEL_REQUIRED; + } + return true; +}); +defineRule("style-required", (value) => { + if (!value || !value.length) { + return errorMessages.STYLE_REQUIRED; + } + return true; +}); +// defineRule("year-required", required(errorMessages.YEAR_REQUIRED)); +// defineRule("make-required", required(errorMessages.MAKE_REQUIRED)); +// defineRule("model-required", required(errorMessages.MODEL_REQUIRED)); +// defineRule("style-required", required(errorMessages.STYLE_REQUIRED)); export default { name: "vehicle", @@ -242,6 +269,9 @@ export default { } } else { this.makeOptions = []; + this.selectedMake = null; + this.selectedModel = null; + this.selectedStyle = null; } }, async selectedMake(make) { @@ -255,6 +285,8 @@ export default { } } else { this.modelOptions = []; + this.selectedModel = null; + this.selectedStyle = null; } }, async selectedModel(model) { @@ -271,6 +303,7 @@ export default { } } else { this.styleOptions = []; + this.selectedStyle = null; } }, async selectedStyle(style) { From 27fc4162b48b1953ca590c34caf1f3cda149d68c Mon Sep 17 00:00:00 2001 From: hiteshkumar87 Date: Wed, 30 Aug 2023 13:18:02 +0530 Subject: [PATCH 04/21] unmatched vehicle and validation unmatched vehicle and validation --- .../dropdown-question/dropdown-question.vue | 10 +++- .../vehicle-question/vehicle-question.vue | 6 ++- src/layouts/vehicle/vehicle.vue | 53 ++++++------------- 3 files changed, 29 insertions(+), 40 deletions(-) diff --git a/src/digital-components/dropdown-question/dropdown-question.vue b/src/digital-components/dropdown-question/dropdown-question.vue index 6c032b740..70bf6c90c 100644 --- a/src/digital-components/dropdown-question/dropdown-question.vue +++ b/src/digital-components/dropdown-question/dropdown-question.vue @@ -26,7 +26,7 @@ {{ value }} -
+
{{ errorMessage }}
@@ -56,6 +56,11 @@ export default { required: false, default: false, }, + disableValidationIfElementDisabled: { + type: Boolean, + required: false, + default: false, + }, }, setup(props) { const uuid = uuidv4(); @@ -110,6 +115,9 @@ export default { this.$emit("update:modelValue", newValue); }, }, + disableValidation() { + return this.disableValidationIfElementDisabled ? !this.isDisabled : true; + }, }, watch: { selectedOption(newValue) { diff --git a/src/layouts/vehicle/vehicle-question/vehicle-question.vue b/src/layouts/vehicle/vehicle-question/vehicle-question.vue index 79b58bfaa..171f5da3f 100644 --- a/src/layouts/vehicle/vehicle-question/vehicle-question.vue +++ b/src/layouts/vehicle/vehicle-question/vehicle-question.vue @@ -1,5 +1,9 @@