From 827c5e6d5861e1712f37fe6f2431bdaec8777731 Mon Sep 17 00:00:00 2001 From: bmauger Date: Wed, 9 Feb 2022 15:59:57 -0500 Subject: [PATCH 1/2] CSR-257 code updates. --- src/common-components/funnel-footer/funnel-footer.vue | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/src/common-components/funnel-footer/funnel-footer.vue b/src/common-components/funnel-footer/funnel-footer.vue index 424e524fc..47dff7b5a 100644 --- a/src/common-components/funnel-footer/funnel-footer.vue +++ b/src/common-components/funnel-footer/funnel-footer.vue @@ -42,14 +42,12 @@ export default { paddingHeight: 0, backLink: "", buttonText: "", - currentYear: new Date().getFullYear(), } }, mounted() { - this.paddingHeight = document.getElementById("infoBox").offsetHeight + 24; + this.paddingHeight = document.querySelector(".footer #infoBox").offsetHeight + 24; this.$nextTick(() => { window.addEventListener('resize', this.onResize); - this.checkHeight(); }) }, beforeUnmount() { @@ -57,12 +55,7 @@ export default { }, methods: { onResize() { - this.paddingHeight = document.getElementById("infoBox").offsetHeight; - this.checkHeight(); - }, - checkHeight() { - const parentHeight = document.getElementById('infoBox').clientHeight; - const wrapper2 = document.getElementById('stacked'); + this.paddingHeight = document.querySelector(".footer #infoBox").offsetHeight; }, initializeComponent(cmsContent) { this.backLink = cmsContent.BackButtonText; From 66503b78500577c941ade34afc0713685e92978b Mon Sep 17 00:00:00 2001 From: bmauger Date: Wed, 9 Feb 2022 16:07:17 -0500 Subject: [PATCH 2/2] Update unit test. --- src/common-components/funnel-footer/funnel-footer.spec.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/common-components/funnel-footer/funnel-footer.spec.js b/src/common-components/funnel-footer/funnel-footer.spec.js index b6833ef7e..1c173b6be 100644 --- a/src/common-components/funnel-footer/funnel-footer.spec.js +++ b/src/common-components/funnel-footer/funnel-footer.spec.js @@ -12,7 +12,7 @@ describe("funnel-footer.vue", () => { offsetHeight: 24, }; - global.document.getElementById = jest.fn().mockImplementation(()=> { + global.document.querySelector = jest.fn().mockImplementation(()=> { return r; });