From 96bde9eb407eeef6de6886098726bd079e2f1ae4 Mon Sep 17 00:00:00 2001 From: CarlNation Date: Tue, 10 Dec 2024 18:42:59 -0500 Subject: [PATCH 1/8] toString on the referralDate issue toString on the referralDate issue. the toString javascript function is adding timezone causing issues after 7pm --- src/store/index.js | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/src/store/index.js b/src/store/index.js index 6a67a9bc7..97fac2d0b 100644 --- a/src/store/index.js +++ b/src/store/index.js @@ -693,10 +693,6 @@ export const mutations = { !sessionInformation.order.payment.isInsurance && !sessionInformation.order.serviceLocation.provider?.providerNumber ) { - console.log( - "------------- updateStateWithOrderInformation reset isInsurance -----------------" - ); - console.log(new Date() + " sessionInformation: " + JSON.stringify(sessionInformation)); state.order.payment.isInsurance = null; } else { state.order.payment.isInsurance = sessionInformation.order.payment.isInsurance; @@ -2104,6 +2100,18 @@ export const actions = { ) { const order = context.state.order; + var dt = new Date(referralDate); + var month = "" + (dt.getMonth() + 1); + var day = "" + dt.getDate(); + const year = dt.getFullYear(); + + if (month.length < 2) + month = "0" + month; + if (day.length < 2) + day = "0" + day; + + const loadDate = `${year}-${month}-${day}`; + return globalMethods .callHttpClient({ method: endpoints.LoadSession.method, @@ -2111,7 +2119,7 @@ export const actions = { payload: { savedSessionId: savedSessionId?.toString(), referralNumber: referralNumber?.toString(), - referralDate: referralDate?.toString(), + referralDate: loadDate, parentAccountNumber: parentAccountNumber?.toString(), referralCorrelationId: referralCorrelationId, }, From a431a58fd558adf7369afab9ad27996f97c7eba4 Mon Sep 17 00:00:00 2001 From: CarlNation Date: Wed, 11 Dec 2024 13:41:36 -0500 Subject: [PATCH 2/8] date functions use client browser for date parts date functions use client browser for date parts. just parse it instead --- src/store/index.js | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/src/store/index.js b/src/store/index.js index 97fac2d0b..d5fa1e0d9 100644 --- a/src/store/index.js +++ b/src/store/index.js @@ -2100,15 +2100,10 @@ export const actions = { ) { const order = context.state.order; - var dt = new Date(referralDate); - var month = "" + (dt.getMonth() + 1); - var day = "" + dt.getDate(); - const year = dt.getFullYear(); - - if (month.length < 2) - month = "0" + month; - if (day.length < 2) - day = "0" + day; + var dtParts = referralDate.split("-"); + const year = dtParts[0]; + const month = dtParts[1]; + const day = dtParts[2].substring(0, 2); const loadDate = `${year}-${month}-${day}`; From 33166f71c664dbeaf5f140822aa4d3f0070dc155 Mon Sep 17 00:00:00 2001 From: CarlNation Date: Wed, 11 Dec 2024 13:58:33 -0500 Subject: [PATCH 3/8] tests tests --- src/store/store.spec.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/store/store.spec.js b/src/store/store.spec.js index 094793bc1..69e2feb66 100644 --- a/src/store/store.spec.js +++ b/src/store/store.spec.js @@ -784,6 +784,7 @@ describe("Actions", () => { const response = await actions.loadSession(context, { payload: { savedSessionId: "", + referralDate: "2024-12-11T00:29:41.967", }, pageNameToLog: "test", }); @@ -813,6 +814,7 @@ describe("Actions", () => { const response = await actions.loadSession(context, { payload: { savedSessionId: "", + referralDate: "2024-12-11T00:29:41.967", }, pageNameToLog: "test", }); @@ -841,6 +843,7 @@ describe("Actions", () => { const response = await actions.loadSession(context, { payload: { savedSessionId: "", + referralDate: "2024-12-11T00:29:41.967", }, pageNameToLog: "test", }); From 5a629be7416d64e82459520c68e89a105a149c63 Mon Sep 17 00:00:00 2001 From: Sneha Date: Thu, 12 Dec 2024 11:49:21 +0530 Subject: [PATCH 4/8] CSR-2486 --- src/layouts/license-plate-lookup/license-plate-lookup.vue | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/layouts/license-plate-lookup/license-plate-lookup.vue b/src/layouts/license-plate-lookup/license-plate-lookup.vue index 2aba11db4..07dea7b21 100644 --- a/src/layouts/license-plate-lookup/license-plate-lookup.vue +++ b/src/layouts/license-plate-lookup/license-plate-lookup.vue @@ -232,6 +232,11 @@ export default { const resultMap = await settleAllPromises(promiseResultMap); // Lookup vin + if (!resultMap.registrationZipValidationResponse.isValid) { + this.displayInvalidZipAlert = true; + return this.$refs.navbar.removeLoader(); + } + const vinLookup = await this.lookupVin( this.licensePlate, resultMap.registrationZipValidationResponse.state @@ -251,7 +256,6 @@ export default { this.displayInvalidZipAlert = true; return this.$refs.navbar.removeLoader(); } - this.displayInvalidZipAlert = false; // Check if the CarId has changed. this.isCarIdDifferent = @@ -346,6 +350,7 @@ export default { this.displayNonServiceableZipAlert = false; this.displayMatchedDifferentVehicleAlert = false; this.displayVinLookupByHomeAddressNotAllowedAlert = false; + this.displayInvalidZipAlert = false; }, }, mounted() { From c6baefd0fb61b963185f06ede95169b8fbc7b61e Mon Sep 17 00:00:00 2001 From: Sneha Date: Thu, 12 Dec 2024 11:52:13 +0530 Subject: [PATCH 5/8] Update license-plate-lookup.vue --- src/layouts/license-plate-lookup/license-plate-lookup.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/layouts/license-plate-lookup/license-plate-lookup.vue b/src/layouts/license-plate-lookup/license-plate-lookup.vue index 07dea7b21..b374e8bb6 100644 --- a/src/layouts/license-plate-lookup/license-plate-lookup.vue +++ b/src/layouts/license-plate-lookup/license-plate-lookup.vue @@ -231,12 +231,12 @@ export default { const resultMap = await settleAllPromises(promiseResultMap); - // Lookup vin if (!resultMap.registrationZipValidationResponse.isValid) { this.displayInvalidZipAlert = true; return this.$refs.navbar.removeLoader(); } + // Lookup vin const vinLookup = await this.lookupVin( this.licensePlate, resultMap.registrationZipValidationResponse.state From 515262488b5efaef29cb9f843bcd5ff96a1ec4c7 Mon Sep 17 00:00:00 2001 From: Scott Kiener Date: Thu, 12 Dec 2024 05:38:38 -0500 Subject: [PATCH 6/8] Changing target pool This is to get around issue in azure on release day 12/12 --- azure-pipelines.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/azure-pipelines.yml b/azure-pipelines.yml index 3ac871d20..fd9044d5f 100644 --- a/azure-pipelines.yml +++ b/azure-pipelines.yml @@ -30,6 +30,9 @@ resources: endpoint: Safelite ref: refs/tags/t5.6.41 +pool: + name: AmazonWindowsPool + variables: - group: Digital-Infrastructure - group: FixMyGlass-BuildBranches From 75bad802a17d6fb697c7fba52d90836883d8c0f8 Mon Sep 17 00:00:00 2001 From: CarlNation Date: Thu, 12 Dec 2024 07:13:39 -0500 Subject: [PATCH 7/8] Revert "Changing target pool" This reverts commit 515262488b5efaef29cb9f843bcd5ff96a1ec4c7. --- azure-pipelines.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/azure-pipelines.yml b/azure-pipelines.yml index fd9044d5f..3ac871d20 100644 --- a/azure-pipelines.yml +++ b/azure-pipelines.yml @@ -30,9 +30,6 @@ resources: endpoint: Safelite ref: refs/tags/t5.6.41 -pool: - name: AmazonWindowsPool - variables: - group: Digital-Infrastructure - group: FixMyGlass-BuildBranches From 4757dd93d0b64999d1acc7f5159b0c33d55a6f90 Mon Sep 17 00:00:00 2001 From: CarlNation Date: Thu, 12 Dec 2024 15:12:47 -0500 Subject: [PATCH 8/8] Do not send safeliteHop amounts less than 0 Do not send safeliteHop amounts less than 0 --- src/layouts/payment/payment.vue | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/layouts/payment/payment.vue b/src/layouts/payment/payment.vue index 062f3c218..2fbe5ca6d 100644 --- a/src/layouts/payment/payment.vue +++ b/src/layouts/payment/payment.vue @@ -604,7 +604,10 @@ export default { cartItems.forEach((item) => { if (item.name !== null && item.category != "promos") { - lineItems.push(`${item.name}|${(item.salesTax + item.subTotal).toFixed(2)}|1`); + const total = (item.salesTax + item.subTotal).toFixed(2); + if (total > 0) { + lineItems.push(`${item.name}|${(item.salesTax + item.subTotal).toFixed(2)}|1`); + } } });