From 4009be32fe9bb85e1300dea0f5786661bef6aaa3 Mon Sep 17 00:00:00 2001 From: Adam Caouette Date: Thu, 26 Oct 2023 15:43:27 -0400 Subject: [PATCH 1/2] CSR-1384: fixes for constant strings refactoring --- .../add-vaps-modal-buttons.vue | 21 +++++++++++++------ 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/src/layouts/payment-method/add-vaps-modal-buttons/add-vaps-modal-buttons.vue b/src/layouts/payment-method/add-vaps-modal-buttons/add-vaps-modal-buttons.vue index fa78915c1..d2195c5e5 100644 --- a/src/layouts/payment-method/add-vaps-modal-buttons/add-vaps-modal-buttons.vue +++ b/src/layouts/payment-method/add-vaps-modal-buttons/add-vaps-modal-buttons.vue @@ -26,7 +26,7 @@ v-if="wipersModal" @footer-button-action="addWipersToCart('WipersModal', wipersModal)" footerButtonActionName="footer-button-action"> -
+
+${{ wipersModal.totalRearPrice }}

-
+

+${{ wipersModal.totalFrontPrice }}

-
+

+${{ wipersModal.totalRearPrice }}

@@ -139,11 +143,13 @@ export default { }, computed: { currentCartItems() { - return this.modelValue; + const modelValue = this.modelValue; + if (!modelValue.vaps) modelValue.vaps = []; + return modelValue; }, rainDefenseModal() { const lineItem = this.availableLineItems.find((item) => { - return item.partType === partTypeStrings.FRONT_WIPER; + return item.partType === partTypeStrings.RAIN_DEFENSE; }); if (lineItem) lineItem.listPrice = parseFloat( @@ -190,7 +196,7 @@ export default { if (!this.answersCmsData) return buttons; const rainDefenseInCart = this.currentCartItems.vaps?.some((vap) => { - return vap?.partType === partTypeStrings.FRONT_WIPER; + return vap?.partType === partTypeStrings.RAIN_DEFENSE; }); const frontWipersInCart = this.currentCartItems.vaps?.some((vap) => { return vap?.partType?.includes(partTypeStrings.FRONT_WIPER); @@ -240,6 +246,9 @@ export default { return buttons; }, + wipersToDisplayStrings() { + return wipersToDisplayStrings; + }, }, components: { buttonQuestion, From 4bbc508aade4af1fe95bb85f518aac7e5bb257ac Mon Sep 17 00:00:00 2001 From: Adam Caouette Date: Fri, 27 Oct 2023 16:40:24 -0400 Subject: [PATCH 2/2] CSR-1384: minor alts to insure against console errors --- .../add-vaps-modal-buttons.vue | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/layouts/payment-method/add-vaps-modal-buttons/add-vaps-modal-buttons.vue b/src/layouts/payment-method/add-vaps-modal-buttons/add-vaps-modal-buttons.vue index d2195c5e5..0c7976ea8 100644 --- a/src/layouts/payment-method/add-vaps-modal-buttons/add-vaps-modal-buttons.vue +++ b/src/layouts/payment-method/add-vaps-modal-buttons/add-vaps-modal-buttons.vue @@ -215,17 +215,17 @@ export default { if (!rainDefenseInCart) { // NO RAIN DEFENSE IN CART; SHOW RAIN DEFENSE BUTTON const modalData = getAnswer("RainDefenseModal", this.answersCmsData); - modalData.SubText = "+$" + this.rainDefenseModal.listPrice; + modalData.SubText = "+$" + this.rainDefenseModal?.listPrice; buttons.push(modalData); } const modalData = getAnswer("WipersModal", this.answersCmsData); if (!frontWipersInCart) { - if (!rearWipersInCart && this.wipersModal.rearWiperLineItems.length > 0) { + if (!rearWipersInCart && this.wipersModal?.rearWiperLineItems.length > 0) { // NO REAR WIPERS or FRONT WIPERS IN CART; SHOW COMBO BUTTON const prices = [ - this.wipersModal.totalFrontPrice, - this.wipersModal.totalRearPrice, + this.wipersModal?.totalFrontPrice, + this.wipersModal?.totalRearPrice, ]; prices.sort((a, b) => a - b); modalData.SubText = "+$" + prices[0] + " - $" + prices[prices.length - 1]; @@ -233,13 +233,13 @@ export default { buttons.push(modalData); } else { // NO FRONT WIPERS IN CART; SHOW ONLY FRONT WIPERS BUTTON - modalData.SubText = "+$" + this.wipersModal.totalFrontPrice; + modalData.SubText = "+$" + this.wipersModal?.totalFrontPrice; this.updateWipersToDisplay(wipersToDisplayStrings.FRONT); buttons.push(modalData); } - } else if (!rearWipersInCart && this.wipersModal.rearWiperLineItems.length > 0) { + } else if (!rearWipersInCart && this.wipersModal?.rearWiperLineItems.length > 0) { // NO REAR WIPERS IN CART; SHOW ONLY REAR WIPERS BUTTON - modalData.SubText = "+$" + this.wipersModal.totalRearPrice; + modalData.SubText = "+$" + this.wipersModal?.totalRearPrice; this.updateWipersToDisplay(wipersToDisplayStrings.REAR); buttons.push(modalData); }