From 9efe9bbc1c964e5df72c2af06ce7e9b1c3d8c323 Mon Sep 17 00:00:00 2001 From: Chloe Herd Date: Wed, 28 Jun 2023 13:11:54 -0400 Subject: [PATCH 1/3] Prevent overwriting of service location data --- src/constants/store-mutations.js | 1 + src/layouts/vin-lookup/vin-lookup.vue | 10 ---------- src/store/index.js | 7 ++++++- 3 files changed, 7 insertions(+), 11 deletions(-) diff --git a/src/constants/store-mutations.js b/src/constants/store-mutations.js index 939caf922..d4e07cf0a 100644 --- a/src/constants/store-mutations.js +++ b/src/constants/store-mutations.js @@ -32,6 +32,7 @@ const storeMutations = { UPDATE_REGISTRATION_LAST_NAME: "updateRegistrationLastName", UPDATE_REGISTRATION: "updateRegistration", + UPDATE_SERVICE_ZIP: "updateServiceZip", UPDATE_SERVICE_LOCATION: "updateServiceLocation", UPDATE_SCHEDULE: "updateSchedule", diff --git a/src/layouts/vin-lookup/vin-lookup.vue b/src/layouts/vin-lookup/vin-lookup.vue index 7da42f302..ddb69ba6f 100644 --- a/src/layouts/vin-lookup/vin-lookup.vue +++ b/src/layouts/vin-lookup/vin-lookup.vue @@ -324,14 +324,9 @@ export default { await this.dispatchStoreAction( storeActions.SAVE_SERVICE_ZIP_CODE_INFO, { - address: "", - address2: "", - city: "", state: resultMap.zipCodeData.state, zipCode: this.serviceZipCode, zipCodeCtu: resultMap.zipCodeData.zipCodeCtu, - appointmentType: "", - isVehicleProtected: null, }, false ); @@ -366,14 +361,9 @@ export default { await this.dispatchStoreAction( storeActions.SAVE_SERVICE_ZIP_CODE_INFO, { - address: null, - address2: null, - city: null, state: zipCodeData.state, zipCode: this.serviceZipCode, zipCodeCtu: zipCodeData.zipCodeCtu, - appointmentType: null, - isVehicleProtected: null, }, false ); diff --git a/src/store/index.js b/src/store/index.js index 4c0057b00..5c290b1cd 100644 --- a/src/store/index.js +++ b/src/store/index.js @@ -244,6 +244,11 @@ export const mutations = { state.order.vehicle.registration.firstName = registrationInfo?.firstName; state.order.vehicle.registration.lastName = registrationInfo?.lastName; }, + updateServiceZip(state, serviceZipInfo) { + state.order.serviceLocation.state = serviceZipInfo.state; + state.order.serviceLocation.zipCode = serviceZipInfo.zipCode; + state.order.serviceLocation.zipCodeCtu = serviceZipInfo.zipCodeCtu; + }, updateServiceLocation(state, serviceLocationInfo) { state.order.serviceLocation.address = serviceLocationInfo.address; state.order.serviceLocation.address2 = serviceLocationInfo.address2; @@ -1905,7 +1910,7 @@ export const actions = { context.commit(storeMutations.RESET_SERVICE_LOCATION_MOBILE_ADDRESS); } - context.commit(storeMutations.UPDATE_SERVICE_LOCATION, serviceZipCodeInfo); + context.commit(storeMutations.UPDATE_SERVICE_ZIP, serviceZipCodeInfo); }, saveServiceLocation(context, serviceLocationInfo) { From 6544c12a0992771a1d763199703fc6a2ab6e6fa4 Mon Sep 17 00:00:00 2001 From: Chloe Herd Date: Wed, 28 Jun 2023 13:20:29 -0400 Subject: [PATCH 2/3] Also change license plate lookup. --- src/layouts/license-plate-lookup/license-plate-lookup.vue | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/layouts/license-plate-lookup/license-plate-lookup.vue b/src/layouts/license-plate-lookup/license-plate-lookup.vue index 4cc69fb16..367e1c938 100644 --- a/src/layouts/license-plate-lookup/license-plate-lookup.vue +++ b/src/layouts/license-plate-lookup/license-plate-lookup.vue @@ -302,16 +302,11 @@ export default { await this.dispatchStoreAction(storeActions.SAVE_EMAIL, this.email, false); await this.dispatchStoreAction( - storeActions.SAVE_SERVICE_LOCATION, + storeActions.SAVE_SERVICE_ZIP_CODE_INFO, { - address: "", - address2: "", - city: "", state: resultMap.serviceZipValidationResponse.state, zipCode: this.serviceZipCode, zipCodeCtu: resultMap.serviceZipValidationResponse.zipCodeCtu, - appointmentType: "", - isVehicleProtected: null, }, false ); From 6c313c151eaf445101c355f2aabb14738630a8d5 Mon Sep 17 00:00:00 2001 From: Leah Schumann Date: Thu, 29 Jun 2023 07:02:54 -0400 Subject: [PATCH 3/3] Moved address-questions into fmg-components per tech review comments --- .../address-questions/address-questions.spec.js | 2 +- .../address-questions/address-questions.vue | 0 .../address-lookup/customer-questions/customer-questions.vue | 2 +- .../mobile-location-modal-questions.vue | 3 +-- 4 files changed, 3 insertions(+), 4 deletions(-) rename src/{layouts/address-lookup/customer-questions => fmg-components}/address-questions/address-questions.spec.js (99%) rename src/{layouts/address-lookup/customer-questions => fmg-components}/address-questions/address-questions.vue (100%) diff --git a/src/layouts/address-lookup/customer-questions/address-questions/address-questions.spec.js b/src/fmg-components/address-questions/address-questions.spec.js similarity index 99% rename from src/layouts/address-lookup/customer-questions/address-questions/address-questions.spec.js rename to src/fmg-components/address-questions/address-questions.spec.js index 26a81341a..f0d508943 100644 --- a/src/layouts/address-lookup/customer-questions/address-questions/address-questions.spec.js +++ b/src/fmg-components/address-questions/address-questions.spec.js @@ -1,5 +1,5 @@ // Components -import addressQuestions from "@/layouts/address-lookup/customer-questions/address-questions/address-questions"; +import addressQuestions from "@/fmg-components/address-questions/address-questions"; import alert from "@/ux-components/alert/alert"; // Supporting Files diff --git a/src/layouts/address-lookup/customer-questions/address-questions/address-questions.vue b/src/fmg-components/address-questions/address-questions.vue similarity index 100% rename from src/layouts/address-lookup/customer-questions/address-questions/address-questions.vue rename to src/fmg-components/address-questions/address-questions.vue diff --git a/src/layouts/address-lookup/customer-questions/customer-questions.vue b/src/layouts/address-lookup/customer-questions/customer-questions.vue index 325f8c380..fcc70765a 100644 --- a/src/layouts/address-lookup/customer-questions/customer-questions.vue +++ b/src/layouts/address-lookup/customer-questions/customer-questions.vue @@ -38,7 +38,7 @@