From 248bca511317ddc954a1e9345b302bf755ebbe8a Mon Sep 17 00:00:00 2001
From: Sneha <sneha.a@safelite.com>
Date: Tue, 29 Oct 2024 18:47:29 +0530
Subject: [PATCH] Tech review changes

---
 src/helpers/service-package-helper.js                |  9 +++++++++
 .../service-package-question.vue                     | 12 ++----------
 2 files changed, 11 insertions(+), 10 deletions(-)

diff --git a/src/helpers/service-package-helper.js b/src/helpers/service-package-helper.js
index 310a87e0e..6ff937564 100644
--- a/src/helpers/service-package-helper.js
+++ b/src/helpers/service-package-helper.js
@@ -239,6 +239,15 @@ export function getPackageNameByType(packageType) {
     return package_names[packageType] || null;
 }
 
+export function getDiscountPackageName(discountPackage) {
+    const package_names = {
+        ECON: packageNames.TIER_ONE,
+        STANDARD: packageNames.TIER_TWO,
+        PREMIUM: packageNames.TIER_THREE,
+    };
+    return package_names[discountPackage] || null;
+}
+
 function maxTier(tierA, tierB) {
     if (tierA === packageNames.TIER_THREE || tierB === packageNames.TIER_THREE) {
         return packageNames.TIER_THREE;
diff --git a/src/layouts/quote/service-package-question/service-package-question.vue b/src/layouts/quote/service-package-question/service-package-question.vue
index e475becd5..7df8dab5f 100644
--- a/src/layouts/quote/service-package-question/service-package-question.vue
+++ b/src/layouts/quote/service-package-question/service-package-question.vue
@@ -28,6 +28,7 @@ import {
     containsLineItemWithPartType,
     findLineItemsWithPartType,
     getPackageNameByType,
+    getDiscountPackageName,
 } from "@/helpers/service-package-helper";
 import {
     getPromosThatMatchLineItemsOnOrder,
@@ -161,16 +162,7 @@ export default {
             const discountServicePackage = experimentMixin.methods.getSettingValue(
                 experimentSettings.PROMO_ON_PACKAGE
             );
-            switch (discountServicePackage) {
-                case "ECON":
-                    return packageNames.TIER_ONE;
-                case "STANDARD":
-                    return packageNames.TIER_TWO;
-                case "PREMIUM":
-                    return packageNames.TIER_THREE;
-                default:
-                    return null;
-            }
+            return getDiscountPackageName(discountServicePackage);
         },
         frontWipersApplicableForTierTwo() {
             return shouldFrontWipersBeAvailable(