From 1cb59b1adce9c9f1202752facb65236530edaa80 Mon Sep 17 00:00:00 2001 From: Minojhini Valaiyapathi Date: Mon, 14 Apr 2025 09:16:05 -0400 Subject: [PATCH] CASH-498 - Code review updates --- src/experiment-components/donation-block.vue | 10 ++++++++-- src/ux-components/button-main/button-main.vue | 14 +------------- 2 files changed, 9 insertions(+), 15 deletions(-) diff --git a/src/experiment-components/donation-block.vue b/src/experiment-components/donation-block.vue index 27ce67918..30fe9f8ed 100644 --- a/src/experiment-components/donation-block.vue +++ b/src/experiment-components/donation-block.vue @@ -56,8 +56,7 @@ ref="buttonMain" :buttonText="DonationAddButtonCopy" loaderColor="blue" - customSecondary="true" - class="w-100 mb-2" + class="w-100 mb-2 custom-secondary" @click-event="handleDonationAction" /> @@ -292,5 +291,12 @@ export default { left: -0.25rem; } } + .custom-secondary { + &:hover { + color: $blue; + background: transparent; + border: 1px solid $blue; + } + } } diff --git a/src/ux-components/button-main/button-main.vue b/src/ux-components/button-main/button-main.vue index fcf78e19b..982e7bb1b 100644 --- a/src/ux-components/button-main/button-main.vue +++ b/src/ux-components/button-main/button-main.vue @@ -3,11 +3,7 @@ :aria-disabled="isDisabled" class="btn d-flex align-items-center justify-content-center py-3 px-4 delay" :class="[ - customSecondary - ? 'btn-secondary custom-secondary' - : isPrimary - ? 'btn-primary' - : 'btn-secondary', + isPrimary ? 'btn-primary' : 'btn-secondary', isFloat ? 'float-end' : '', isLoaderDisplayed && !suppressLoader ? 'has-loader' : '', ]" @@ -33,7 +29,6 @@ export default { loaderPosition: String, isFloat: Boolean, suppressLoader: Boolean, - customSecondary: Boolean, // New property to check if it comes from donationBlock }, data() { return { @@ -161,13 +156,6 @@ export default { transition: background 0s 0s ease-in-out; } } - &.custom-secondary { - &:hover { - color: $blue !important; - background: transparent !important; - border: 1px solid $blue; - } - } &.btn-success { position: relative; background: $green-100;