From 2391748d6059e5231439e9cf7556c3e7c60d64ee Mon Sep 17 00:00:00 2001 From: Matt Sykes Date: Mon, 30 Mar 2026 14:39:30 -0400 Subject: [PATCH 1/2] Always set vm.isInsuranceSelected Some cases were not setting it if external parameter state was marked 0 or 1 --- src/layouts/quote/quote.vue | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/src/layouts/quote/quote.vue b/src/layouts/quote/quote.vue index b428ab905..339e543df 100644 --- a/src/layouts/quote/quote.vue +++ b/src/layouts/quote/quote.vue @@ -583,6 +583,8 @@ export default { debugLog("--- quote.vue thresholds end ---"); } + let setInsuranceSelected = true; + if (isExternalParameter === externalParameterStatus.NOT_SET) { // prettier-ignore { @@ -590,12 +592,6 @@ export default { } // there are no active or inactive external parameters; use internal threshold if (internalThreshold) thresholdToUse = internalThreshold; - - vm.isInsuranceSelected = getIsInsuranceSelectedValue( - vm.availableLineItems, - thresholdToUse - ); - baseMixin.methods.ResetExternalParamsAndHideModal(); } else { // user came from an external source, however, the externalParms may have been reset on service-zip, property-questions, etc... if (getBoolFromString(store.getters.externalParameterQuote?.isInsurance)) { @@ -614,7 +610,9 @@ export default { await vm.skip(insuranceSelection, servicePackage); } - baseMixin.methods.ResetExternalParamsAndHideModal(); + if (vm.isInsuranceSelected != null) { + setInsuranceSelected = false; + } } else { if (externalThreshold) thresholdToUse = externalThreshold; @@ -622,13 +620,16 @@ export default { { debugLog("quote.vue tab select NOT EXTERNAL"); } + } + //Set isInsuranceSelected if + if (setInsuranceSelected) { vm.isInsuranceSelected = getIsInsuranceSelectedValue( vm.availableLineItems, thresholdToUse ); - baseMixin.methods.ResetExternalParamsAndHideModal(); } + baseMixin.methods.ResetExternalParamsAndHideModal(); } if (vm.skipToInsurance && !vm.showSaveProgressPopup) { From 849443fa1c849b946720a1b7809aaac4e9ae08b6 Mon Sep 17 00:00:00 2001 From: Matt Sykes Date: Mon, 30 Mar 2026 15:42:33 -0400 Subject: [PATCH 2/2] simplify logic -> set isInsuranceSelected if its null/undefined --- src/layouts/quote/quote.vue | 23 ++++++++--------------- 1 file changed, 8 insertions(+), 15 deletions(-) diff --git a/src/layouts/quote/quote.vue b/src/layouts/quote/quote.vue index 339e543df..106c04bfa 100644 --- a/src/layouts/quote/quote.vue +++ b/src/layouts/quote/quote.vue @@ -583,8 +583,6 @@ export default { debugLog("--- quote.vue thresholds end ---"); } - let setInsuranceSelected = true; - if (isExternalParameter === externalParameterStatus.NOT_SET) { // prettier-ignore { @@ -609,10 +607,6 @@ export default { ) { await vm.skip(insuranceSelection, servicePackage); } - - if (vm.isInsuranceSelected != null) { - setInsuranceSelected = false; - } } else { if (externalThreshold) thresholdToUse = externalThreshold; @@ -621,17 +615,16 @@ export default { debugLog("quote.vue tab select NOT EXTERNAL"); } } - - //Set isInsuranceSelected if - if (setInsuranceSelected) { - vm.isInsuranceSelected = getIsInsuranceSelectedValue( - vm.availableLineItems, - thresholdToUse - ); - } - baseMixin.methods.ResetExternalParamsAndHideModal(); } + if (vm.isInsuranceSelected == null) { + vm.isInsuranceSelected = getIsInsuranceSelectedValue( + vm.availableLineItems, + thresholdToUse + ); + } + baseMixin.methods.ResetExternalParamsAndHideModal(); + if (vm.skipToInsurance && !vm.showSaveProgressPopup) { // skip ahead only if no email popup. await vm.skip(true, externalParamPackageLabels.GLASS_ONLY);