Merge pull request #2043 from Safelite/feature/CSR-2276

CSR-2276 if request is from leadgen then use external threshold
This commit is contained in:
scottkiener 2024-10-24 08:53:14 -04:00 committed by GitHub
commit 0e90016f6c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 11 additions and 7 deletions

View file

@ -346,6 +346,9 @@ export default {
let internalThreshold = experimentMixin.methods.getSettingValue( let internalThreshold = experimentMixin.methods.getSettingValue(
experimentSettings.INSURANCE_TAB_TO_DISPLAY_THRESHOLD_INTERNAL experimentSettings.INSURANCE_TAB_TO_DISPLAY_THRESHOLD_INTERNAL
); );
let externalThreshold = experimentMixin.methods.getSettingValue(
experimentSettings.INSURANCE_TAB_TO_DISPLAY_THRESHOLD_EXTERNAL
);
const isExternalParameter = store.getters.externalParameterState?.isExternalParameter; const isExternalParameter = store.getters.externalParameterState?.isExternalParameter;
if ( if (
@ -353,7 +356,11 @@ export default {
isExternalParameter === externalParameterStatus.INACTIVE isExternalParameter === externalParameterStatus.INACTIVE
) { ) {
// there are no active or inactive external parameters; use internal threshold // there are no active or inactive external parameters; use internal threshold
if (internalThreshold) thresholdToUse = internalThreshold; if (isExternalParameter === externalParameterStatus.INACTIVE) {
if (internalThreshold) thresholdToUse = externalThreshold;
} else {
if (internalThreshold) thresholdToUse = internalThreshold;
}
vm.isInsuranceSelected = getIsInsuranceSelectedValue( vm.isInsuranceSelected = getIsInsuranceSelectedValue(
vm.availableLineItems, vm.availableLineItems,
@ -374,9 +381,6 @@ export default {
baseMixin.methods.ResetExternalParamsAndHideModal(); baseMixin.methods.ResetExternalParamsAndHideModal();
} }
} else { } else {
const externalThreshold = experimentMixin.methods.getSettingValue(
experimentSettings.INSURANCE_TAB_TO_DISPLAY_THRESHOLD_EXTERNAL
);
thresholdToUse = externalThreshold; thresholdToUse = externalThreshold;
vm.isInsuranceSelected = getIsInsuranceSelectedValue( vm.isInsuranceSelected = getIsInsuranceSelectedValue(