CSR-762 Remove redundant property'

This commit is contained in:
Katie 2022-10-17 09:36:19 -04:00
parent bdefe44235
commit 0e3b1d79b8
8 changed files with 6 additions and 19 deletions

View file

@ -26,10 +26,7 @@
import { useField } from "vee-validate"; import { useField } from "vee-validate";
import { toRef } from "vue"; import { toRef } from "vue";
import { queryStrings } from "@/constants/query-strings"; import { queryStrings } from "@/constants/query-strings";
import { import { handleInputFocus, handleInputBlur } from "@/helpers/analytics-helper";
handleInputFocus,
handleInputBlur,
} from "@/helpers/analytics-helper";
import { inputButtonProps } from "@/common-components/base-input-button/button-functionality-props"; import { inputButtonProps } from "@/common-components/base-input-button/button-functionality-props";
export default { export default {
@ -72,9 +69,9 @@ export default {
); );
break; break;
case this.eventTypes.CHANGE: case this.eventTypes.CHANGE:
this.selectOnKeypress this.selectingInitiatesLoad
? this.handleClick(e) ? this.handleSelectionChange(e)
: this.handleSelectionChange(e); : this.handleClick(e);
break; break;
} }
} }

View file

@ -23,8 +23,8 @@ export const inputButtonProps = {
}, },
lastValuePushedToGa: [String, Number], lastValuePushedToGa: [String, Number],
setLastValuePushedToGa: Function, setLastValuePushedToGa: Function,
selectOnKeypress: { selectingInitiatesLoad: {
type: Boolean, type: Boolean,
default: true, default: false,
}, },
} }

View file

@ -49,7 +49,6 @@
:isWide="isWide" :isWide="isWide"
:validationRules="validationRules" :validationRules="validationRules"
:textPosition="textPosition" :textPosition="textPosition"
:selectOnKeypress="selectOnKeypress"
:lastValuePushedToGa="lastValuePushedToGa" :lastValuePushedToGa="lastValuePushedToGa"
:setLastValuePushedToGa="setLastValuePushedToGa" :setLastValuePushedToGa="setLastValuePushedToGa"
v-model="selectedValues" v-model="selectedValues"
@ -117,10 +116,6 @@ export default {
suppressError: Boolean, suppressError: Boolean,
useTextForValue: Boolean, useTextForValue: Boolean,
valueToLogType: String, valueToLogType: String,
selectOnKeypress: {
type: Boolean,
default: true,
},
}, },
data() { data() {
return { return {

View file

@ -8,7 +8,6 @@
groupName="ChooseVehicleMake" groupName="ChooseVehicleMake"
textPosition="text-start" textPosition="text-start"
v-model="selectedValue" v-model="selectedValue"
:selectOnKeypress="false"
isRequired isRequired
/> />
</template> </template>

View file

@ -8,7 +8,6 @@
groupName="ChooseVehicleModel" groupName="ChooseVehicleModel"
textPosition="text-start" textPosition="text-start"
v-model="selectedValue" v-model="selectedValue"
:selectOnKeypress="false"
isRequired isRequired
/> />
</template> </template>

View file

@ -8,7 +8,6 @@
groupName="ChooseVehicleStyle" groupName="ChooseVehicleStyle"
textPosition="text-start" textPosition="text-start"
v-model="selectedValue" v-model="selectedValue"
:selectOnKeypress="false"
isRequired isRequired
/> />
</template> </template>

View file

@ -8,7 +8,6 @@
groupName="ChooseVehicleYear" groupName="ChooseVehicleYear"
textPosition="text-start" textPosition="text-start"
v-model="selectedValue" v-model="selectedValue"
:selectOnKeypress="false"
isRequired isRequired
/> />
</template> </template>

View file

@ -49,7 +49,6 @@ export default {
const currentPageName = getPageNameByQueryString(); const currentPageName = getPageNameByQueryString();
const labelToLog = getValueToLog(label, valueToLogType); const labelToLog = getValueToLog(label, valueToLogType);
console.log("PUSHING: ", labelToLog)
const eventToBePushed = { const eventToBePushed = {
'event': GaEvents.GENERIC_EVENT, 'event': GaEvents.GENERIC_EVENT,
'category': category, 'category': category,