jason/DigitalConsumer.FixMyGlass
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #1662 from Safelite/feature/skiener/CSR-1862

Browse source 
CSR-1862 | Avoid clearing valid and active promo on page load
This commit is contained in:
scottkiener 2023-12-27 10:17:57 -05:00 committed by GitHub
commit 0c37dce7a5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 19 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
src/helpers/promotions-helper.js
View file

@ -149,16 +149,25 @@ export async function revalidatePromosAndValidateQueryStringPromo(
} else if (!excludeFromInactivePromoErrorCodes.includes(validatePromoResponse.errorCode)) { } else if (!excludeFromInactivePromoErrorCodes.includes(validatePromoResponse.errorCode)) {
// Save any valid query string promoCode (not applied) to inactivePromos // Save any valid query string promoCode (not applied) to inactivePromos
// in order to not lose the query string promoCode if back button is pressed // in order to not lose the query string promoCode if back button is pressed
const inactivePromoCodes = store.getters.payment.inactivePromos ?? []; const activePromoCodes = store.getters.order.lineItems.promos.map((promoObject) => {
if (!inactivePromoCodes.includes(newPromo)) { return promoObject.promoCode.toUpperCase();
inactivePromoCodes.push(newPromo); });
baseMixin.methods.dispatchStoreAction( const isErrorPromoAlreadyOnOrder = activePromoCodes.includes(
storeActions.SAVE_ACTIVE_AND_OR_INACTIVE_PROMOS, validatePromoResponse.promoCode.toUpperCase()
{ );
inactivePromos: inactivePromoCodes, // Do not save an inactivePromo if it is already active on the order
}, if (!isErrorPromoAlreadyOnOrder) {
false const inactivePromoCodes = store.getters.payment.inactivePromos ?? [];
); if (!inactivePromoCodes.includes(newPromo)) {
inactivePromoCodes.push(newPromo);
baseMixin.methods.dispatchStoreAction(
storeActions.SAVE_ACTIVE_AND_OR_INACTIVE_PROMOS,
{
inactivePromos: inactivePromoCodes,
},
false
);
}
} }
} }
} }