From ba2aec00d62b430e8fd2842daf33cd37de0a2f52 Mon Sep 17 00:00:00 2001 From: Max Date: Tue, 23 Nov 2021 16:14:39 -0500 Subject: [PATCH 1/7] integrating updated radio buttons --- .../radio-question/radio-question.vue | 20 ++++--- src/ux-components/radio/radio.vue | 56 ++++++++++++------- 2 files changed, 48 insertions(+), 28 deletions(-) diff --git a/src/common-components/radio-question/radio-question.vue b/src/common-components/radio-question/radio-question.vue index d17020dfc..b6428233a 100644 --- a/src/common-components/radio-question/radio-question.vue +++ b/src/common-components/radio-question/radio-question.vue @@ -5,14 +5,18 @@ questionText }} -
-
- +
+
+

*

+
diff --git a/src/ux-components/radio/radio.vue b/src/ux-components/radio/radio.vue index ac005bca4..3da9c6ea5 100644 --- a/src/ux-components/radio/radio.vue +++ b/src/ux-components/radio/radio.vue @@ -1,35 +1,51 @@ From 3b3af03d8f336b062cf431d4bd8d2e2978197440 Mon Sep 17 00:00:00 2001 From: Max Date: Tue, 23 Nov 2021 16:54:34 -0500 Subject: [PATCH 2/7] Adjusting unit test for new radio --- src/ux-components/radio/radio.spec.js | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/ux-components/radio/radio.spec.js b/src/ux-components/radio/radio.spec.js index 35ddfdab7..0fcb8e701 100644 --- a/src/ux-components/radio/radio.spec.js +++ b/src/ux-components/radio/radio.spec.js @@ -2,22 +2,21 @@ import { shallowMount } from "@vue/test-utils"; import radio from "./radio"; describe("radio.vue", () => { - it("Should render the 'text' prop value as a span value for the radio button label and add the 'value' prop value as the radio button value and id.", () => { + it("Should render the 'radioID' prop value as a span value for the radio button label.", () => { // Act const wrapper = shallowMount(radio, { propsData: { - value: "2023", - text: "12", + radioID: "2023", + groupName: "TestGroup" }, }); // Assert - expect(wrapper.find("span").text()).toEqual("12"); expect(wrapper.find("input").attributes()).toEqual({ - class: "position-absolute opacity-0", id: "2023", type: "radio", value: "2023", - }); + name: "TestGroup", + }) }); }); From c92112e07faa636d807f733b8c5a06c9f2302a63 Mon Sep 17 00:00:00 2001 From: Max Date: Tue, 23 Nov 2021 17:13:09 -0500 Subject: [PATCH 3/7] Updating testing for radioTest with new radio buttons --- src/common-components/radio-question/radio-question.spec.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/common-components/radio-question/radio-question.spec.js b/src/common-components/radio-question/radio-question.spec.js index da58ea8d1..eac0843e5 100644 --- a/src/common-components/radio-question/radio-question.spec.js +++ b/src/common-components/radio-question/radio-question.spec.js @@ -19,8 +19,7 @@ describe("radioQuestion.vue", () => { "Question Text" ); const radioButtons = wrapper.findAllComponents('[data-test="radio"]'); - expect(radioButtons[0].attributes("text")).toEqual("2023"); - expect(radioButtons[2].attributes("text")).toEqual("2021"); + expect(radioButtons.length).toBe(3); expect(typeof wrapper.props().chooseAnswer).toBe("function"); }); }); From f3ecb534b29084f0531c772fa4440a42222e5cd0 Mon Sep 17 00:00:00 2001 From: bmauger Date: Wed, 24 Nov 2021 09:26:16 -0500 Subject: [PATCH 4/7] CSR-185 alert qa updates. --- src/ux-components/alert/alert.vue | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/src/ux-components/alert/alert.vue b/src/ux-components/alert/alert.vue index 811dcb133..84c139916 100644 --- a/src/ux-components/alert/alert.vue +++ b/src/ux-components/alert/alert.vue @@ -2,8 +2,8 @@