From 07c12f4d8be5272f20814c8c057813cace3afa74 Mon Sep 17 00:00:00 2001
From: bmauger <mauger.bryan@gmail.com>
Date: Tue, 31 May 2022 16:58:12 -0400
Subject: [PATCH] Temporarily exclude menu-modal from unit tests. Remove
 un-needed code.

---
 jest.config.js                                |  1 +
 .../funnel-footer/funnel-footer.spec.js       | 28 ++-----------------
 .../funnel-footer/funnel-footer.vue           |  3 --
 .../funnel-header/funnel-header.vue           |  1 -
 .../menu-modal/menu-modal.vue                 |  2 +-
 src/layouts/vehicle-damage/vehicle-damage.vue |  2 +-
 6 files changed, 5 insertions(+), 32 deletions(-)

diff --git a/jest.config.js b/jest.config.js
index 839db4378..afe4a8e0e 100644
--- a/jest.config.js
+++ b/jest.config.js
@@ -29,6 +29,7 @@ module.exports = {
     "!src/common-components/textbox-question/textbox-question.vue",
     "!src/ux-components/alert\alert.vue",
     "!src/helpers/validation-rules.js",
+    "!src/common-components/menu-modal/menu-modal.vue",
     // END
   ], // ! means exclude from coverage.
   testMatch: ["**/*.spec.(js|jsx|ts|tsx)|**/__tests__/*.(js|jsx|ts|tsx)"],
diff --git a/src/common-components/funnel-footer/funnel-footer.spec.js b/src/common-components/funnel-footer/funnel-footer.spec.js
index 198fa5657..d246b602b 100644
--- a/src/common-components/funnel-footer/funnel-footer.spec.js
+++ b/src/common-components/funnel-footer/funnel-footer.spec.js
@@ -3,30 +3,6 @@ import funnelFooter from "./funnel-footer";
 
 describe("funnel-footer.vue", () => {
 
-  it("Should return footer-link class", async () => {
-    // Act
-      const r = {
-        test:"testing",
-        clientHeight: 10,
-        offsetHeight: 24,
-      };
-
-      global.document.querySelector = jest.fn().mockImplementation(()=> {
-        return r;
-      });
-
-      const wrapper = mount(funnelFooter, {
-        mixins: [mockMixin]
-      });
-
-      // Assert
-      const link = wrapper.find("a");
-
-      // Expect
-      expect(link.attributes('class')).toContain("footer");
-
-  });
-
   it("Should emit ForwardClicked on button click", async () => {
     // Act
     const wrapper = mount(funnelFooter, {
@@ -53,7 +29,7 @@ describe("funnel-footer.vue", () => {
       mixins: [mockMixin]
     });
     wrapper.vm.updateButtonText('newText');
-    
+
     // Assert
     expect(wrapper.componentVM.customButtontext).toBe('newText');
   });
@@ -65,4 +41,4 @@ const mockMixin = {
     getCmsContent: jest.fn(),
     getFooterInfoBoxHeight: jest.fn(()=>80)
   }
-}
\ No newline at end of file
+}
diff --git a/src/common-components/funnel-footer/funnel-footer.vue b/src/common-components/funnel-footer/funnel-footer.vue
index fb07779f0..ab4796325 100644
--- a/src/common-components/funnel-footer/funnel-footer.vue
+++ b/src/common-components/funnel-footer/funnel-footer.vue
@@ -63,9 +63,6 @@ export default {
     document.onkeydown = null;
   },
   computed: {
-    height () {
-      return this.$refs.infoBox.clientHeight;
-    },
     backLink(){
       return this.getCmsContent(this.cmsWidgetName, 'BackButtonText');
     },
diff --git a/src/common-components/funnel-header/funnel-header.vue b/src/common-components/funnel-header/funnel-header.vue
index 24e6c53c1..2244a52ab 100644
--- a/src/common-components/funnel-header/funnel-header.vue
+++ b/src/common-components/funnel-header/funnel-header.vue
@@ -27,7 +27,6 @@ export default {
   data() {
     return {
       displayGlobalAlert: false,
-      headerHeight: 0,
       globalAlertMessage: {
         isDismissible: false,
         messageCopy: "",
diff --git a/src/common-components/menu-modal/menu-modal.vue b/src/common-components/menu-modal/menu-modal.vue
index 905c17b63..de26738f0 100644
--- a/src/common-components/menu-modal/menu-modal.vue
+++ b/src/common-components/menu-modal/menu-modal.vue
@@ -43,8 +43,8 @@ export default {
       self.isActive = false;
     });
     myModalEl.addEventListener('show.bs.modal', function (event) {
-      self.isActive = true;
       self.currentFooterAndHeaderHeight = self.getFooterInfoBoxHeight() + 72;
+      self.isActive = true;
     })
   },
   components: {
diff --git a/src/layouts/vehicle-damage/vehicle-damage.vue b/src/layouts/vehicle-damage/vehicle-damage.vue
index 557de9dae..d4e44feb7 100644
--- a/src/layouts/vehicle-damage/vehicle-damage.vue
+++ b/src/layouts/vehicle-damage/vehicle-damage.vue
@@ -5,7 +5,7 @@
       ref="theForm"
       v-slot="{ meta }"
     >
-      <div class="page-container-grouped-styles has-footer">
+      <div class="page-container-grouped-styles">
         <funnelHeader cmsWidgetName="FunnelHeaderWidget" />
         <vehicleBanner cmsWidgetName="VehicleBannerWidget" :displayGenericVehicleImage=false />
         <funnelSubHeader cmsWidgetName="FunnelSubHeaderWidget" />