Tweaks to dev changes

This commit is contained in:
Chloe Herd 2024-09-26 17:34:13 -04:00
parent a0cec6e83e
commit 06a2d381fa
3 changed files with 17 additions and 24 deletions

View file

@ -108,6 +108,7 @@ import { getDisplayTextForDurationLength } from "@/helpers/duration-length-helpe
import { experimentSettings } from "@/constants/experiments"; import { experimentSettings } from "@/constants/experiments";
import { partTypeStrings } from "@/constants/part-type-strings"; import { partTypeStrings } from "@/constants/part-type-strings";
import { containsLineItemWithPartType } from "@/helpers/service-package-helper"; import { containsLineItemWithPartType } from "@/helpers/service-package-helper";
import { containsRecalParts } from "@/helpers/recal-helper.js";
export default { export default {
name: "confirmation", name: "confirmation",
@ -170,10 +171,7 @@ export default {
}, },
computed: { computed: {
isRecalibrationOnOrder() { isRecalibrationOnOrder() {
return containsLineItemWithPartType( return containsRecalParts(this?.lineItems);
partTypeStrings.RECALIBRATION,
this?.lineItems?.supportingItems
);
}, },
shouldHideRecalibration() { shouldHideRecalibration() {
return ( return (

View file

@ -583,9 +583,8 @@ export default {
if (tier) { if (tier) {
let lineItemsToPrice = this.availableLineItems; let lineItemsToPrice = this.availableLineItems;
if (this.isRecalibrationOnOrder && this.shouldHideRecalibration) { if (this.isRecalibrationOnOrder && this.shouldHideRecalibration) {
lineItemsToPrice = lineItemsToPrice?.filter((item) => { lineItemsToPrice =
return item.partType != partTypeStrings.RECALIBRATION; baseMixin.methods.filterOutRecalibration(lineItemsToPrice);
});
} }
if (this.isServicePackageDiscountOnOrder) { if (this.isServicePackageDiscountOnOrder) {
lineItemsToPrice = lineItemsToPrice?.filter((item) => { lineItemsToPrice = lineItemsToPrice?.filter((item) => {
@ -609,12 +608,7 @@ export default {
}); });
eventLabel = eventLabel.slice(0, -1); eventLabel = eventLabel.slice(0, -1);
this.pushEventToGA( this.pushEventToGA("quote", this.GaActions.SERVICE_PACKAGE_PRICE, eventLabel, true);
"quote",
this.GaActions.SERVICE_PACKAGE_PRICE,
eventLabel,
true
);
}); });
}, },
}, },

View file

@ -4003,17 +4003,18 @@ describe("Getters", () => {
requiresCapabilityQuestions: false, requiresCapabilityQuestions: false,
childParts: [ childParts: [
{ {
"partNumber": "THIRD RECAL", partNumber: "THIRD RECAL",
"description": "Additional Static Recal", description: "Additional Static Recal",
"recalibrationType": "DUAL & RECAL THIRD & HC FUNCTION TEST & RL SENSOR", recalibrationType:
"ribCode": "RL", "DUAL & RECAL THIRD & HC FUNCTION TEST & RL SENSOR",
"safelitePartNumber": "THIRD RECAL", ribCode: "RL",
"status": "ACTIVE", safelitePartNumber: "THIRD RECAL",
"partType": "ADAS RECALIBRATION", status: "ACTIVE",
"childParts": [], partType: "ADAS RECALIBRATION",
"recalibrationFees": [], childParts: [],
"salesTax": null recalibrationFees: [],
} salesTax: null,
},
], ],
}, },
], ],