Tweaks to dev changes

This commit is contained in:
Chloe Herd 2024-09-26 17:34:13 -04:00
parent a0cec6e83e
commit 06a2d381fa
3 changed files with 17 additions and 24 deletions

View file

@ -108,6 +108,7 @@ import { getDisplayTextForDurationLength } from "@/helpers/duration-length-helpe
import { experimentSettings } from "@/constants/experiments";
import { partTypeStrings } from "@/constants/part-type-strings";
import { containsLineItemWithPartType } from "@/helpers/service-package-helper";
import { containsRecalParts } from "@/helpers/recal-helper.js";
export default {
name: "confirmation",
@ -170,10 +171,7 @@ export default {
},
computed: {
isRecalibrationOnOrder() {
return containsLineItemWithPartType(
partTypeStrings.RECALIBRATION,
this?.lineItems?.supportingItems
);
return containsRecalParts(this?.lineItems);
},
shouldHideRecalibration() {
return (

View file

@ -583,9 +583,8 @@ export default {
if (tier) {
let lineItemsToPrice = this.availableLineItems;
if (this.isRecalibrationOnOrder && this.shouldHideRecalibration) {
lineItemsToPrice = lineItemsToPrice?.filter((item) => {
return item.partType != partTypeStrings.RECALIBRATION;
});
lineItemsToPrice =
baseMixin.methods.filterOutRecalibration(lineItemsToPrice);
}
if (this.isServicePackageDiscountOnOrder) {
lineItemsToPrice = lineItemsToPrice?.filter((item) => {
@ -609,12 +608,7 @@ export default {
});
eventLabel = eventLabel.slice(0, -1);
this.pushEventToGA(
"quote",
this.GaActions.SERVICE_PACKAGE_PRICE,
eventLabel,
true
);
this.pushEventToGA("quote", this.GaActions.SERVICE_PACKAGE_PRICE, eventLabel, true);
});
},
},

View file

@ -4003,17 +4003,18 @@ describe("Getters", () => {
requiresCapabilityQuestions: false,
childParts: [
{
"partNumber": "THIRD RECAL",
"description": "Additional Static Recal",
"recalibrationType": "DUAL & RECAL THIRD & HC FUNCTION TEST & RL SENSOR",
"ribCode": "RL",
"safelitePartNumber": "THIRD RECAL",
"status": "ACTIVE",
"partType": "ADAS RECALIBRATION",
"childParts": [],
"recalibrationFees": [],
"salesTax": null
}
partNumber: "THIRD RECAL",
description: "Additional Static Recal",
recalibrationType:
"DUAL & RECAL THIRD & HC FUNCTION TEST & RL SENSOR",
ribCode: "RL",
safelitePartNumber: "THIRD RECAL",
status: "ACTIVE",
partType: "ADAS RECALIBRATION",
childParts: [],
recalibrationFees: [],
salesTax: null,
},
],
},
],