From 73d7a64d19a4918c9ac28f0b220e9cc8dae09dea Mon Sep 17 00:00:00 2001 From: Leah Schumann Date: Tue, 23 May 2023 09:01:04 -0400 Subject: [PATCH 1/3] Bryan pointed out I was diplaying the streetAddress where the city should be --- src/layouts/service-location/shop-question/shop-question.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/layouts/service-location/shop-question/shop-question.vue b/src/layouts/service-location/shop-question/shop-question.vue index fffb36c49..3183cbc9e 100644 --- a/src/layouts/service-location/shop-question/shop-question.vue +++ b/src/layouts/service-location/shop-question/shop-question.vue @@ -143,7 +143,7 @@ export default { const distanceInMiles = Math.round(shopProvider.distanceInMiles * 2) / 2; return { - buttonLabel: streetAddress, + buttonLabel: city, buttonLabelSubCopy: `${distanceInMiles} mi`, buttonBodyCopy: `${streetAddress}, ${city}, ${state} ${zipCode}`, value: shopProvider.providerNumber, From b3813eedb150e1e71536efbc8bdec37ceec92af7 Mon Sep 17 00:00:00 2001 From: Chloe Herd Date: Tue, 23 May 2023 09:09:54 -0400 Subject: [PATCH 2/3] Revert CSR-1367 --- .../text-block/text-block.vue | 9 +- src/layouts/review/review.spec.js | 3 - src/layouts/review/review.vue | 102 ------------------ src/router/index.js | 6 -- 4 files changed, 2 insertions(+), 118 deletions(-) delete mode 100644 src/layouts/review/review.spec.js delete mode 100644 src/layouts/review/review.vue diff --git a/src/digital-components/text-block/text-block.vue b/src/digital-components/text-block/text-block.vue index 3a608f3a0..4f9c41599 100644 --- a/src/digital-components/text-block/text-block.vue +++ b/src/digital-components/text-block/text-block.vue @@ -1,7 +1,7 @@ @@ -11,11 +11,6 @@ export default { props: { customText: String, // used to allow the insert of token values into textblock justifyText: String, // left, right, center - margin: { - // bootstrap margin to apply to the block. - type: String, - default: "mt-2", - }, typeStyle: String, // h1-h6, body, small, label, caption (see Figma or Confluence documentation) fontWeight: String, // bold=500, default is 400 cmsWidgetName: String, diff --git a/src/layouts/review/review.spec.js b/src/layouts/review/review.spec.js deleted file mode 100644 index 674dc71f7..000000000 --- a/src/layouts/review/review.spec.js +++ /dev/null @@ -1,3 +0,0 @@ -describe("Review Page", () => { - test.todo("Add more tests as specific functionality is added."); -}); diff --git a/src/layouts/review/review.vue b/src/layouts/review/review.vue deleted file mode 100644 index 9bccb2014..000000000 --- a/src/layouts/review/review.vue +++ /dev/null @@ -1,102 +0,0 @@ - - - - - diff --git a/src/router/index.js b/src/router/index.js index 86c402187..3abfa058d 100644 --- a/src/router/index.js +++ b/src/router/index.js @@ -31,7 +31,6 @@ import { applicationConfig } from "../constants/application-config"; // Components import datePicker from "@/digital-components/date-picker/date-picker.vue"; import demoDatePicker from "@/layouts/demo-date-picker/demo-date-picker.vue"; -import review from "@/layouts/review/review"; const routes = [ { @@ -44,11 +43,6 @@ const routes = [ name: "date-picker", component: datePicker, }, - { - path: "/review", // This is a temporary route for testing. - name: "review", - component: review, - }, { path: "/", name: "root", From 0e167607ad0882c06d492f735d6fc5240c3a4750 Mon Sep 17 00:00:00 2001 From: Leah Schumann Date: Tue, 23 May 2023 09:13:31 -0400 Subject: [PATCH 3/3] Fixed unit tests --- .../shop-question/shop-question.spec.js | 24 +++++++++---------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/src/layouts/service-location/shop-question/shop-question.spec.js b/src/layouts/service-location/shop-question/shop-question.spec.js index c61fe2720..c4efdea91 100644 --- a/src/layouts/service-location/shop-question/shop-question.spec.js +++ b/src/layouts/service-location/shop-question/shop-question.spec.js @@ -179,19 +179,19 @@ describe("shop-question.vue", () => { expect(wrapper.vm.answers).toEqual([ { buttonBodyCopy: "4403 Executive Pkwy, Westerville, OH 43081", - buttonLabel: "4403 Executive Pkwy", + buttonLabel: "Westerville", buttonLabelSubCopy: "5 mi", value: "003335", }, { buttonBodyCopy: "760 Dearborn Park Ln, Worthington, OH 43085", - buttonLabel: "760 Dearborn Park Ln", + buttonLabel: "Worthington", buttonLabelSubCopy: "10.5 mi", value: "001820", }, { buttonBodyCopy: "5015 N High St, Columbus, OH 43214", - buttonLabel: "5015 N High St", + buttonLabel: "Columbus", buttonLabelSubCopy: "11.5 mi", value: "003343", }, @@ -320,19 +320,19 @@ describe("shop-question.vue", () => { const displayedAnswers = [ { buttonBodyCopy: "4403 Executive Pkwy, Westerville, OH 43081", - buttonLabel: "4403 Executive Pkwy", + buttonLabel: "Westerville", buttonLabelSubCopy: "5 mi", value: "003335", }, { buttonBodyCopy: "760 Dearborn Park Ln, Worthington, OH 43085", - buttonLabel: "760 Dearborn Park Ln", + buttonLabel: "Worthington", buttonLabelSubCopy: "10.5 mi", value: "001820", }, { buttonBodyCopy: "5015 N High St, Columbus, OH 43214", - buttonLabel: "5015 N High St", + buttonLabel: "Columbus", buttonLabelSubCopy: "11.5 mi", value: "003343", }, @@ -388,37 +388,37 @@ describe("shop-question.vue", () => { expect(wrapper.vm.answers).toEqual([ { buttonBodyCopy: "4403 Executive Pkwy, Westerville, OH 43081", - buttonLabel: "4403 Executive Pkwy", + buttonLabel: "Westerville", buttonLabelSubCopy: "5 mi", value: "003335", }, { buttonBodyCopy: "760 Dearborn Park Ln, Worthington, OH 43085", - buttonLabel: "760 Dearborn Park Ln", + buttonLabel: "Worthington", buttonLabelSubCopy: "10.5 mi", value: "001820", }, { buttonBodyCopy: "5015 N High St, Columbus, OH 43214", - buttonLabel: "5015 N High St", + buttonLabel: "Columbus", buttonLabelSubCopy: "11.5 mi", value: "003343", }, { buttonBodyCopy: "1670 Harmon Ave, Columbus, OH 43223", - buttonLabel: "1670 Harmon Ave", + buttonLabel: "Columbus", buttonLabelSubCopy: "16 mi", value: "006747", }, { buttonBodyCopy: "3938 Powell Rd, Powell, OH 43065", - buttonLabel: "3938 Powell Rd", + buttonLabel: "Powell", buttonLabelSubCopy: "16.5 mi", value: "003341", }, { buttonBodyCopy: "4580 W Broad St, Columbus, OH 43228", - buttonLabel: "4580 W Broad St", + buttonLabel: "Columbus", buttonLabelSubCopy: "19.5 mi", value: "003342", },