From 7548603b165135e7cf9c47bfe0209fb30da7645c Mon Sep 17 00:00:00 2001 From: Bryan Mauger Date: Thu, 19 Jan 2023 14:40:53 -0500 Subject: [PATCH 1/4] CSR-1097 add comment for REM calculation. --- src/styles/common-typography-styles.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/styles/common-typography-styles.scss b/src/styles/common-typography-styles.scss index a1b2a5e2b..1344c53fb 100644 --- a/src/styles/common-typography-styles.scss +++ b/src/styles/common-typography-styles.scss @@ -42,7 +42,7 @@ h6, .small { font-size: 0.875rem; - line-height: 1.7142857143; + line-height: 1.7142857143; // 24px specified in Figma. REM value calculation 24px/14px=1.7142857143 font-weight: 400; } From 14a06b32832baf35e814a79121ceb687c13553bc Mon Sep 17 00:00:00 2001 From: Bryan Mauger Date: Fri, 20 Jan 2023 08:44:21 -0500 Subject: [PATCH 2/4] Remove space to trigger build. --- src/styles/common-typography-styles.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/styles/common-typography-styles.scss b/src/styles/common-typography-styles.scss index 1344c53fb..6ce9bf6f2 100644 --- a/src/styles/common-typography-styles.scss +++ b/src/styles/common-typography-styles.scss @@ -42,7 +42,7 @@ h6, .small { font-size: 0.875rem; - line-height: 1.7142857143; // 24px specified in Figma. REM value calculation 24px/14px=1.7142857143 + line-height: 1.7142857143;// 24px specified in Figma. REM value calculation 24px/14px=1.7142857143 font-weight: 400; } From edc5a8c3c6ac43015e9f6af8c60b7ab340f9ac5f Mon Sep 17 00:00:00 2001 From: Bryan Mauger Date: Fri, 20 Jan 2023 10:06:55 -0500 Subject: [PATCH 3/4] Revert line height to standardized number. --- src/styles/common-typography-styles.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/styles/common-typography-styles.scss b/src/styles/common-typography-styles.scss index 6ce9bf6f2..0286bd046 100644 --- a/src/styles/common-typography-styles.scss +++ b/src/styles/common-typography-styles.scss @@ -42,7 +42,7 @@ h6, .small { font-size: 0.875rem; - line-height: 1.7142857143;// 24px specified in Figma. REM value calculation 24px/14px=1.7142857143 + line-height: 1.7 font-weight: 400; } From 5a37eec9ffd29e3501ae4096f2b2dad83117f472 Mon Sep 17 00:00:00 2001 From: Bryan Mauger Date: Fri, 20 Jan 2023 10:38:53 -0500 Subject: [PATCH 4/4] Fix missing semicolon. --- src/styles/common-typography-styles.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/styles/common-typography-styles.scss b/src/styles/common-typography-styles.scss index 0286bd046..72b2e5875 100644 --- a/src/styles/common-typography-styles.scss +++ b/src/styles/common-typography-styles.scss @@ -42,7 +42,7 @@ h6, .small { font-size: 0.875rem; - line-height: 1.7 + line-height: 1.7; font-weight: 400; }