Merge pull request #738 from Safelite/feature/CSR-835-2

trying to fix repair-chips
This commit is contained in:
Mark Harris 2022-09-14 08:25:57 -04:00 committed by GitHub
commit 0079988604
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 16 additions and 4 deletions

View file

@ -173,11 +173,16 @@ export default {
if(this.selectingInitiatesLoad) {
this.selectedValues = val.value;
} else {
if(Array.isArray(this.selectedValues)) {
if(this.isMultiSelect) {
const newSelectedValues = this.selectedValues;
val.checkValue ? newSelectedValues.push(val.value) : newSelectedValues.splice(newSelectedValues.indexOf(val.value), 1);
this.selectedValues = newSelectedValues;
}
else if (Array.isArray(this.selectedValues)) {
this.selectedValues[0] = val.value;
const temp = this.selectedValues;
this.selectedValues = temp;
}
else {
this.selectedValues = val.value;
}

View file

@ -47,7 +47,8 @@ export default ({
return this.modelValue;
},
set: function(newValue) {
this.$emit("update:modelValue", newValue);
const numberValue = Number(newValue);
this.$emit("update:modelValue", numberValue);
}
},
},

View file

@ -942,8 +942,14 @@ export const actions = {
.slice()
.sort()
.every((obj, index) => obj.glassLocation === selectedGlassPassedInSorted[index].glassLocation && obj.glassName === selectedGlassPassedInSorted[index].glassName);
const isWindshieldRepairTheSame = isWindshieldRepair === context.state.order.damage.isRepair;
const isChipCountTheSame = Array.isArray(selectedWindshieldChipCount) //TODO: fix the underlying components so this is never an array
? selectedWindshieldChipCount[0] === context.state.order.damage.numberOfChips
: selectedWindshieldChipCount === context.state.order.damage.numberOfChips;
if (!isGlassToReplaceTheSame) {
const isDamageChanging = !isGlassToReplaceTheSame || !isWindshieldRepairTheSame || (isWindshieldRepair && !isChipCountTheSame);
if (isDamageChanging) {
//Reset dependent state when changing
context.dispatch(storeActions.RESET_PARTS_STATE_AND_DEPENDENCIES);

View file

@ -122,7 +122,7 @@ export default {
handleCheckChange() {
const emitEvent = {
checkValue: this.checkValue, // only read on checkboxes, on handleCheckedChanged on button-question
value: this.value.toString(),
value: this.value,
buttonId: this.buttonID && this.buttonID.toString(),
};